chore: upgrade circleci config to v2.1 #6312
Merged
+67
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, the tests for this PR are still using the old config --edit-- Fyi, i checked the config with the cli tool: nuxt.js# circleci config validate
Config file at .circleci/config.yml is valid. |
Codecov Report
@@ Coverage Diff @@
## dev #6312 +/- ##
=====================================
Coverage 95.7% 95.7%
=====================================
Files 79 79
Lines 2652 2652
Branches 683 683
=====================================
Hits 2538 2538
Misses 98 98
Partials 16 16
Continue to review full report at Codecov.
|
pimlie
commented
Aug 26, 2019
clarkdo
reviewed
Aug 26, 2019
|
@clarkdo Feel free to make changes to this pr yourself if you really believe this is a blocking issue |
|
I don’t think it anything is blocked, it’s just in reviewing, we can hear feedback from others, if no concerns, it can be merged |
|
Cool |
atinux
pushed a commit
that referenced
this pull request
Aug 28, 2019
* [release] * fix(vue-app): enforce default css when used with frameworks (#6255) * chore(deps): update dependency serialize-javascript to ^1.8.0 (#6254) * fix(config): provide typescript backward compatibility (#6258) * fix(vue-app): only overwrite leave listener when none provided or without done arg (#6264) * fix(nuxt-start): add missing `vue-client-only` dependency (#6267) * fix(server): treat `https: null` as `https: undefined` (#6265) * chore(deps): update devdependency rollup to ^1.20.0 (#6268) * fix: improve watching experience for generated files (#6257) * refactor(core): use hable (#6271) * test: disable terser/minify by default (#6290) * chore(deps): update devdependency rollup to ^1.20.1 (#6282) * chore(cli): accept hooks (#6274) * chore(deps): update devdependency rollup-plugin-alias to v2 (#6281) * fix(builder): apply overrides from app dir only (#6283) [release] * feat: function watchQuery (#6245) * Revert "feat: function watchQuery (#6245)" (#6296) This reverts commit 3c61830. * chore(deps): update devdependency rollup to ^1.20.2 (#6295) Co-authored-by: Renovate Bot <bot@renovateapp.com> * test(vue-app): add template compiler helper (#6299) * test: add jest roots for less greedy test search (#6300) * test: remove unnecessary generate (#6301) * fix: update the minimal require node version in distributions (#6310) * chore(deps): update devdependency babel-eslint to ^10.0.3 (#6304) * chore(deps): lock file maintenance (#6305) * chore: upgrade circleci config to v2.1 (#6312) * test: add test for modern bundle size (#6302) * test: add client-only test to basic fixture (#6315) test: check for no-ssr deprecation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This upgrades the current circleci config to
v2.1. One of the main benefits ofv2.1is that builds can be automatically cancelled when a new build is triggered, see here for more info. This could save some time in some cases.This config is based on the config I have been using for
nuxt/vue-metaandnuxt/pressChecklist: