fix(webpack): fix consola IE compatibility #6298

clarkdo · 2019-08-25T10:59:40Z

See #5743

Types of changes

Bug fix (a non-breaking change which fixes an issue)
New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly. (PR: #)
I have added tests to cover my changes (if not applicable, please state why)
All new and existing tests are passing.

codecov-io · 2019-08-25T11:05:52Z

Codecov Report

Merging #6298 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6298   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          79       79           
  Lines        2693     2693           
  Branches      697      697           
=======================================
  Hits         2575     2575           
  Misses        101      101           
  Partials       17       17

Flag	Coverage Δ
#e2e	`100% <ø> (ø)`	⬆️
#fixtures	`50.64% <ø> (ø)`	⬆️
#unit	`92.31% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
packages/webpack/src/config/base.js	`94.68% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e043f...0e34018. Read the comment docs.

clarkdo · 2019-08-25T11:22:25Z

packages/webpack/src/config/base.js

@@ -215,7 +216,7 @@ export default class WebpackBaseConfig {
  alias () {
    return {
      ...this.buildContext.options.alias,
-      consola: require.resolve(`consola/dist/consola${this.isServer ? '' : '.browser'}.js`)
+      consola: require.resolve(`consola/${this.isServer ? 'dist/consola' : 'src/browser'}.js`)


Because consola server build will bundle dependencies like dayjs which are not in deps of Nuxt, so use dist/consola.js for server build.

clarkdo · 2019-09-22T20:25:28Z

@pi0

galvez

LGTM

pi0 · 2019-09-29T08:58:57Z

An overall description of different methods to resolve this issue and why going with method of PR.

Problem: We use consola only for development mode. The browser dist use some features that IE9 does not support that makes debugging impossible during dev for IE.

Solutions:

Include babel-polyfill in browser build (fix: include polyfills for browser build unjs/consola#67)
Build from source (this PR)

As consola is only used for dev for browser, our main priority is best DX (not best perf for end-users) and best DX is fastest nuxt dev. Pretranspilation usually increases build time (like BootstrapVue) but for consola, it seems not. Polyfills to the dist add ~22kB to the bundle size which seems to make webpack even slower!

Silly benchmark:

Src: 3.95 / 3.67 / 3.37 / 3.49
Dist with polyfill: 4.6 / 4.06 / 3.9 / 4.13 / 3.84 / 3.82

AndrewBogdanovTSS · 2019-09-29T17:01:57Z

@pi0 will it affect production build size in any way or it only increases dev bundle?

pi0 · 2019-09-29T17:33:59Z

@AndrewBogdanovTSS no it is dev only. And no effect on dev bundle as we had it as before.

AndrewBogdanovTSS · 2019-09-29T17:49:36Z

@pi0 you meant no effect on prod bundle?

TheAlexLichter · 2019-09-29T19:29:54Z

@AndrewBogdanovTSS No change for the prod bundle, no "noticable" effect for the dev bundle besides IE11 compat ☺️

AndrewBogdanovTSS · 2019-10-02T16:04:02Z

Just updated my project to Nuxt v.2.10.0 - IE still throw errors about Consola in dev mode:

SCRIPT1002: Syntax Error
vendors.app.js (36605,1)
    class Consola {...

clarkdo · 2019-10-02T17:09:03Z

I’ll have a look

feat: build consola from src

65fa419

clarkdo requested a review from pi0 August 25, 2019 10:59

clarkdo changed the title ~~feat: build consola from src~~ feat(webpack): build consola from src Aug 25, 2019

feat: use dist/consola.js for server

3a82432

clarkdo commented Aug 25, 2019

View reviewed changes

clarkdo mentioned this pull request Sep 4, 2019

fix: include polyfills for browser build unjs/consola#67

Closed

Merge branch 'dev' into consola-src

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

0e34018

galvez previously approved these changes Sep 27, 2019

View reviewed changes

TheAlexLichter previously approved these changes Sep 28, 2019

View reviewed changes

Merge branch 'dev' into consola-src

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

55945d9

pi0 dismissed stale reviews from TheAlexLichter and galvez via 55945d9 September 29, 2019 08:51

fix typo

03c3fbd

pi0 approved these changes Sep 29, 2019

View reviewed changes

pi0 changed the title ~~feat(webpack): build consola from src~~ fix(webpack): fix consola IE compatibility Sep 29, 2019

pi0 merged commit d1df5c8 into dev Sep 29, 2019

pi0 deleted the consola-src branch September 29, 2019 09:02

pi0 mentioned this pull request Sep 30, 2019

v2.10.0 #6468

Merged

clarkdo mentioned this pull request Oct 2, 2019

fix(vue-app, webpack): remove consola from client #6504

Merged

7 tasks

This was referenced Nov 12, 2019

[Snyk] Upgrade nuxt from 2.6.3 to 2.10.2 ajesse11x/webgems#1

Open

[Snyk] Upgrade nuxt from 2.9.1 to 2.10.2 Matthelonianxl/nuxtjs#1

Open

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade nuxt from 1.0.0-rc11 to 2.10.2 ajesse11x/css-houdini.rocks#8

Open

snyk-bot mentioned this pull request Dec 12, 2019

[Snyk] Upgrade nuxt from 2.10.0 to 2.10.2 Asthriona/Ashtriona-Blog#2

Merged

This was referenced Apr 15, 2020

[Snyk] Upgrade nuxt from 2.5.1 to 2.12.0 mc-ireiser/nuxt-leaflet#4

Open

[Snyk] Upgrade nuxt from 2.8.1 to 2.12.0 mc-ireiser/termodaq_app#6

Open

danielroe added the 2.x label Jan 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

fix(webpack): fix consola IE compatibility #6298

fix(webpack): fix consola IE compatibility #6298

clarkdo commented Aug 25, 2019 •

edited by TheAlexLichter

Loading

codecov-io commented Aug 25, 2019 •

edited

Loading

clarkdo Aug 25, 2019 •

edited

Loading

clarkdo commented Sep 22, 2019

galvez left a comment

pi0 commented Sep 29, 2019 •

edited

Loading

AndrewBogdanovTSS commented Sep 29, 2019

pi0 commented Sep 29, 2019

AndrewBogdanovTSS commented Sep 29, 2019

TheAlexLichter commented Sep 29, 2019

AndrewBogdanovTSS commented Oct 2, 2019 •

edited

Loading

clarkdo commented Oct 2, 2019

fix(webpack): fix consola IE compatibility #6298

fix(webpack): fix consola IE compatibility #6298

Conversation

clarkdo commented Aug 25, 2019 • edited by TheAlexLichter Loading

Types of changes

Description

Checklist:

codecov-io commented Aug 25, 2019 • edited Loading

Codecov Report

clarkdo Aug 25, 2019 • edited Loading

Choose a reason for hiding this comment

clarkdo commented Sep 22, 2019

galvez left a comment

Choose a reason for hiding this comment

pi0 commented Sep 29, 2019 • edited Loading

AndrewBogdanovTSS commented Sep 29, 2019

pi0 commented Sep 29, 2019

AndrewBogdanovTSS commented Sep 29, 2019

TheAlexLichter commented Sep 29, 2019

AndrewBogdanovTSS commented Oct 2, 2019 • edited Loading

clarkdo commented Oct 2, 2019

clarkdo commented Aug 25, 2019 •

edited by TheAlexLichter

Loading

codecov-io commented Aug 25, 2019 •

edited

Loading

clarkdo Aug 25, 2019 •

edited

Loading

pi0 commented Sep 29, 2019 •

edited

Loading

AndrewBogdanovTSS commented Oct 2, 2019 •

edited

Loading