Skip to content

fix(vue-app): reduce consola direct access #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2019
Merged

fix(vue-app): reduce consola direct access #5864

merged 2 commits into from
Jun 4, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 4, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Consola is a fancy wrapper. Directly using for server bundle adds extra dependency which is unnecessary for serverless environments
  • Don't override console.log for browser. fixes Optional Consola #5842

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@codecov-io
Copy link

Codecov Report

Merging #5864 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5864      +/-   ##
==========================================
- Coverage   95.72%   95.68%   -0.04%     
==========================================
  Files          82       82              
  Lines        2690     2690              
  Branches      690      690              
==========================================
- Hits         2575     2574       -1     
- Misses         97       98       +1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.37% <ø> (ø) ⬆️
#unit 92.67% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 93.49% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c0889...59f0d0d. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #5864 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5864      +/-   ##
==========================================
- Coverage   95.72%   95.68%   -0.04%     
==========================================
  Files          82       82              
  Lines        2690     2690              
  Branches      690      690              
==========================================
- Hits         2575     2574       -1     
- Misses         97       98       +1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.37% <ø> (ø) ⬆️
#unit 92.67% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 93.49% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c0889...59f0d0d. Read the comment docs.

@atinux atinux self-requested a review June 4, 2019 12:49
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional Consola
4 participants