revert: revert node-externals disabling in dev mode #5452
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is reverting #5414 since including all
node_modules
will cause problems.So for fixing dev mode memory leak issue, we suggest user using
build.standalone: true
.standalone
mode will include allnode_modules
intoserver bundle file
and avoid shared Vue module in Node.js main process which leads to memory leak in dev mode.But one thing need to be notified is: If all
node_modules
all bundled intoserver.js
by webpack, the modules which are using Node.js globals and modules like__dirname
won't work as be resolved successfully by webpack, so those modules need to be declared in webpackexternals
.For example:
firebase
and its dependencygrpc
are using__direname
, so the config would be like: