Skip to content

fix(renderer): retry render if renderer is in loading or created state #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 29, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@pi0 pi0 requested a review from a team March 29, 2019 20:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: pi0 <pyapar@gmail.com>
@pi0 pi0 requested a review from TheAlexLichter March 30, 2019 18:42
@pi0 pi0 dismissed TheAlexLichter’s stale review March 30, 2019 18:42

suggestion applied

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pi0 pi0 requested a review from a team March 30, 2019 18:49
@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #5417 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5417   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          74       74           
  Lines        2536     2536           
  Branches      645      645           
=======================================
  Hits         2438     2438           
  Misses         82       82           
  Partials       16       16
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 95.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82bde15...2abac64. Read the comment docs.

@pi0 pi0 merged commit 8b99695 into dev Mar 30, 2019
@pi0 pi0 deleted the fix/renderer-loading branch March 30, 2019 19:12
@pi0 pi0 mentioned this pull request Mar 31, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants