Skip to content

fix(vue-app): decode router base to support unicode characters #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

TheAlexLichter
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4948

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@TheAlexLichter TheAlexLichter changed the title fix: decode router base to support unicodes fix: decode router base to support unicode characters Mar 20, 2019
@aldarund
Copy link

How about test ? :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@TheAlexLichter
Copy link
Member Author

TheAlexLichter commented Mar 20, 2019

@aldarund WIP ;)

(I always forget to create a draft PR 🙄 )

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #5297 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5297      +/-   ##
=========================================
- Coverage   95.7%   95.66%   -0.04%     
=========================================
  Files         74       74              
  Lines       2513     2513              
  Branches     639      639              
=========================================
- Hits        2405     2404       -1     
- Misses        91       92       +1     
  Partials      17       17
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 91.58% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e9f78...15ca2be. Read the comment docs.

@TheAlexLichter TheAlexLichter requested review from clarkdo and pi0 March 20, 2019 14:12
@TheAlexLichter TheAlexLichter mentioned this pull request Mar 20, 2019
@aldarund
Copy link

What if they specify base: '/öl' - will it work?
Also what if they specify non decodable uri base? How graceful error will be?

@TheAlexLichter
Copy link
Member Author

What if they specify base: '/öl' - will it work?

It will. I can change the test to it if you want ☺️

Also what if they specify non decodable uri base? How graceful error will be?

If you specify an URL base that's non-decodable, you should receive errors way earlier, as it has to go through the server first.

@atinux atinux self-requested a review March 20, 2019 15:52
@atinux atinux changed the title fix: decode router base to support unicode characters fix(vue-app): decode router base to support unicode characters Mar 20, 2019
@pi0 pi0 merged commit 3ac01df into dev Mar 20, 2019
@TheAlexLichter TheAlexLichter deleted the fix/unicode-base branch March 20, 2019 22:09
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

router.base value with Extended unicode (åäö) fails
6 participants