-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix(vue-app): decode router base to support unicode characters #5297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How about test ? :) |
@aldarund (I always forget to create a draft PR 🙄 ) |
Codecov Report
@@ Coverage Diff @@
## dev #5297 +/- ##
=========================================
- Coverage 95.7% 95.66% -0.04%
=========================================
Files 74 74
Lines 2513 2513
Branches 639 639
=========================================
- Hits 2405 2404 -1
- Misses 91 92 +1
Partials 17 17
Continue to review full report at Codecov.
|
What if they specify base: '/öl' - will it work? |
It will. I can change the test to it if you want
If you specify an URL base that's non-decodable, you should receive errors way earlier, as it has to go through the server first. |
Types of changes
Description
Resolves #4948
Checklist: