Skip to content

fix: extra properties in templateFiles #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Feb 1, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

If t is string like 'app/template.js', the returned object will be:

{
	0: "a"
	1: "p"
	2: "p"
	3: "/"
	4: "t"
	5: "e"
	6: "m"
	7: "p"
	8: "l"
	9: "a"
	10: "t"
	11: "e"
	12: "."
	13: "j"
	14: "s",
	src: '...',
	dst: '...',
	custom: '...'
}

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
PowerKiKi Adrien Crivelli
@clarkdo clarkdo requested a review from pi0 February 1, 2019 16:03
@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #4925 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4925      +/-   ##
==========================================
+ Coverage   91.71%   91.79%   +0.08%     
==========================================
  Files          73       73              
  Lines        2414     2414              
  Branches      594      594              
==========================================
+ Hits         2214     2216       +2     
+ Misses        182      180       -2     
  Partials       18       18
Impacted Files Coverage Δ
packages/builder/src/builder.js 88.98% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 95.65% <0%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268851f...e532e56. Read the comment docs.

@pi0 pi0 changed the base branch from dev to 2.x February 1, 2019 16:22
@pi0 pi0 changed the base branch from 2.x to dev February 1, 2019 16:22
@pi0 pi0 merged commit ca19124 into nuxt:dev Feb 1, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the template_props branch April 2, 2019 13:15
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants