Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade highlightjs to 11.x #979

Merged
merged 1 commit into from Oct 21, 2021
Merged

docs: upgrade highlightjs to 11.x #979

merged 1 commit into from Oct 21, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 21, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In documentation, we are mentioning highlight.js usage while internally still depending on 10.x with deprecated API. This PR upgrades docs, internal tests to latest API

Release notes: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@pi0 pi0 merged commit 6515436 into main Oct 21, 2021
@pi0 pi0 deleted the feat/highlightjs-upgrade branch October 21, 2021 11:09
@NozomuIkuta
Copy link
Collaborator

Oh, that was the problem...!
Thank you for fixing it! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants