Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename example-multiselect component #926

Merged
merged 1 commit into from Oct 21, 2021

Conversation

NozomuIkuta
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #920.

In addition, I added a box-style to the preview, for it to be consistent with the corresponding part.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

I checked UI in my local, and now it works.

Comment on lines +335 to +339
<div class="border rounded-md p-2 mb-2 bg-gray-200 dark:bg-gray-800">

<example-multiselect :options="multiselectOptions"></example-multiselect>

</div>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a box-style to make it consistent with the part below:

<div class="border rounded-md p-2 mb-2 bg-gray-200 dark:bg-gray-800">
Please choose a <i>framework</i>:

<example-multiselect :options="['Vue', 'React', 'Angular', 'Svelte']"></example-multiselect>

</div>

@NozomuIkuta NozomuIkuta added bug Something isn't working documentation Improvements or additions to documentation labels Sep 22, 2021
@pi0 pi0 changed the title fix(docs): rename global component docs: rename example-multiselect component Oct 21, 2021
@pi0 pi0 merged commit 7d1aa87 into nuxt:main Oct 21, 2021
@NozomuIkuta NozomuIkuta deleted the fix/docs-component branch October 21, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Vue Components example doesn't display component
2 participants