Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): update type definition for QueryBuilder.fetch() #825

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

yz4230
Copy link
Contributor

@yz4230 yz4230 commented Mar 14, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • NEW! Update type definition

Description

Just fix QueryBuilder.fetch() return type definition.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Sorry, something went wrong.

@atinux atinux requested review from atinux and danielroe March 15, 2021 13:19
@atinux atinux changed the title Update type definition of QueryBuilder.fetch() (#816) chore(types): Update type definition of QueryBuilder.fetch() (#816) Mar 15, 2021
Comment on lines 16 to 20
toc?: {
id: string;
depth: number;
text: string;
}[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be added to IContentDocument instead of duplicating it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will introduce IContentDocumentBase to avoid code duplication.
And add missing body field too.

@yz4230 yz4230 requested a review from danielroe April 17, 2021 00:28
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you ❤️

@danielroe danielroe changed the title chore(types): Update type definition of QueryBuilder.fetch() (#816) chore(types): update type definition for QueryBuilder.fetch() (#816) Apr 17, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 pi0 changed the title chore(types): update type definition for QueryBuilder.fetch() (#816) fix(content): update type definition for QueryBuilder.fetch() Oct 21, 2021
@pi0 pi0 merged commit 4cc224e into nuxt:main Oct 21, 2021
@nozomuikuta
Copy link
Collaborator

@yz4230

This PR has been released as Nuxt Content v1.15.0!
Check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants