Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add darkMode option #135

Closed
Atinux opened this issue Aug 4, 2020 · 3 comments
Closed

Add darkMode option #135

Atinux opened this issue Aug 4, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
3.1

Comments

@Atinux
Copy link
Collaborator

Atinux commented Aug 4, 2020

Is your feature request related to a problem? Please describe.

The integration with tailwindcss-dark-mode with @nuxtjs/color-mode is not great, as well with the Tailwind Typography plugin.

Describe the solution you'd like

Supporting the darkMode: true option to add our dark mode plugin we use here.
@Atinux Atinux added the enhancement New feature or request label Aug 4, 2020
@Atinux Atinux added this to the 3.1 milestone Aug 4, 2020
@divine
Copy link

divine commented Sep 5, 2020

Tailwindcss has now experimental dark mode tailwindlabs/tailwindcss#2279

I think this might be easier to implement.

Thanks!

@Atinux
Copy link
Collaborator Author

Atinux commented Sep 14, 2020

Indeed, at first we need to update the @nuxtjs/color-mode package to support the new Tailwind option to customize the class.

@Atinux
Copy link
Collaborator Author

Atinux commented Sep 16, 2020

Since Tailwind v1.8+ supports dark mode now and @nuxtjs/color-mode v1.1.0 is out, no need to have such feature now :)

@Atinux Atinux closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
3 participants
@benjamincanac @Atinux @divine