Skip to content

fix: allow overriding all "webpackConfig" options #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

rchl
Copy link
Member

@rchl rchl commented Aug 19, 2021

Apart from allowing all webpackConfig options to be overridden, also
deprecate "webpackConfig" and other publish-release-specific options
and accept a configuration object for the "publishRelease" option.

Apart from allowing all webpackConfig options to be overridden, also
deprecate "webpackConfig" and other publish-release-specific options
and accept a configuration object for the "publishRelease" option.
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #338 (eaf2544) into master (d344d6f) will increase coverage by 4.68%.
The diff coverage is 87.50%.

❗ Current head eaf2544 differs from pull request most recent head 08d0b61. Consider uploading reports for the commit 08d0b61 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   69.23%   73.91%   +4.68%     
==========================================
  Files           1        1              
  Lines          39       46       +7     
  Branches       19       21       +2     
==========================================
+ Hits           27       34       +7     
  Misses          9        9              
  Partials        3        3              
Impacted Files Coverage Δ
lib/module.js 73.91% <87.50%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d344d6f...08d0b61. Read the comment docs.

@rchl rchl merged commit bbc46d7 into master Aug 19, 2021
@rchl rchl deleted the fix/setcommits branch August 19, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant