Skip to content

docs: clarification between module and native sentry options #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

MentalGear
Copy link
Contributor

It's confusing that "configuration" is both used for the native sentry options (config object), as well as for the module options. I tried to clarify this a bit in this PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
It's confusing that "configuration" is both used for the native sentry options (config object), as well as for the module options. I tried to clarify this a bit in this PR.
@MentalGear MentalGear mentioned this pull request Apr 28, 2021
@MentalGear MentalGear changed the title Clarification between Options and Config docs: Clarification between Options and Config Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #313 (a4b723a) into master (9e3ae22) will not change coverage.
The diff coverage is n/a.

❗ Current head a4b723a differs from pull request most recent head 528f8dd. Consider uploading reports for the commit 528f8dd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           1        1           
  Lines          27       27           
  Branches        8        8           
=======================================
  Hits           15       15           
  Misses          9        9           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3ae22...528f8dd. Read the comment docs.

@MentalGear MentalGear closed this Apr 29, 2021
@MentalGear MentalGear reopened this Apr 29, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@rchl rchl changed the title docs: Clarification between Options and Config docs: clarification between module and native sentry options Apr 29, 2021
@rchl rchl merged commit f7b84d5 into nuxt-community:master Apr 29, 2021
@MentalGear MentalGear deleted the patch-1 branch April 29, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants