fix: handle commonjs/es import styles for @sentry/cli

[snake575]

Fixes #301

[codecov]

Codecov Report

Merging #302 (d64249b) into master (eed66db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           1        1           
  Lines          27       27           
  Branches        8        8           
=======================================
  Hits           15       15           
  Misses          9        9           
  Partials        3        3           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed66db...d64249b. Read the comment docs.

[snake575]

@rchl I noticed that @sentry/webpack-plugin already gets the release version with proposeVersion by default:

https://github.com/getsentry/sentry-webpack-plugin/blob/fbd610c22abf94b41f3056d7f69fb32a96e95314/src/index.js#L86

Maybe it's not necessary to implement the same feature on this module?

[rchl]

@rchl I noticed that @sentry/webpack-plugin already gets the release version with proposeVersion by default:

getsentry/sentry-webpack-plugin@fbd610c/src/index.js#L86

Maybe it's not necessary to implement the same feature on this module?

I think the release needs to be set in the config that is generated at build-time even if publishRelease is enabled as webpack-plugin won't update the module's config.

Feel free to correct me if I'm wrong as I don't fully remember how everything works now.

[snake575]

I think the release needs to be set in the config that is generated at build-time even if publishRelease is enabled as webpack-plugin won't update the module's config.

Feel free to correct me if I'm wrong as I don't fully remember how everything works now.

I made new branch deleting the implementation to test this (it works). Maybe was implemented to fix some edge case?

master...snake575:sentry-webpack-default-release

The uploaded release matches this branch last commit ID

https://github.com/snake575/nuxt-sentry/tree/sentry-webpack-default-release

https://github.com/snake575/nuxt-sentry/commit/2ae0ea493bf09fc219661f77c535b88eca2b5e1c

[rchl]

But are issues reported with the correct version still?

Besides, I think that even when you have not enabled publishRelease, you still want the correct version to be reported in the issues.

[snake575]

You're right, on the branch eliminating the implementation, issues get reported on sentry but not on any release.