-
Notifications
You must be signed in to change notification settings - Fork 111
feat: Add runtime config support #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 55.55% 55.55%
=======================================
Files 1 1
Lines 27 27
Branches 8 8
=======================================
Hits 15 15
Misses 9 9
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing:
- documentation
- similar change in
plugin.lazy.js
- What about server-side? Even though on server-side options are "runtime", the user might want to use the runtime config for both server and client-side rather than having to specify them in both places.
Thanks for the review, I'll do that tomorrow. |
@rchl I did all the requested changes.
|
I've tested it on my site and there is a bug in the config merge, I'll investigate tomorrow. For now I'll set the draft mode on this Pull Request. |
It works now. @rchl can you review it again? Thanks! |
26fcbbf
to
f124a1c
Compare
@rchl Just did a rebase onto master. Is there something blocking this PR from being merged? Thanks! |
Just lack of time but will try to handle soon |
bab5f54
to
c147bc4
Compare
Would you be able to enable the option that allows maintainers to push to this branch? I could do some minor changes myself instead of the long way with comments and turnarounds. |
Done! I invited you directly, the option "Allow edits from maintainers" wasn't available. |
Since, if in the future we also want to support privateRuntimeConfig, it IMO makes sense to have the same key for both.
OK, I've done some changes. You can have a look through the commits I've added and check if it looks good to you. |
LGTM 👍 |
Thanks! |
Sorry to jump in on this late. To confirm, the |
A bit weird maybe but you can probably set any |
This PR adds a new configuration key:
publicRuntimeConfigKey
, it defaults tosentry
when publicRuntimeConfig exists.It fixes #202, and inspired by #203, thanks to @Ledarath