Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_url did respond but not via service worker #372

Closed
shadow81627 opened this issue Oct 13, 2020 · 8 comments · Fixed by elirehema/nbs-web#89
Closed

start_url did respond but not via service worker #372

shadow81627 opened this issue Oct 13, 2020 · 8 comments · Fixed by elirehema/nbs-web#89

Comments

@shadow81627
Copy link

I am trying to figure out why my PWA isn't being installed on android as a WebAPK any more. The add to home screen is just creating a shortcut rather than the WebAPK. I ran a lighthouse audit that is erroring on start_url does not respond with a 200 when offline.

I am using Vercel for hosting so it could be an issue related to #367 #352 but it seems like the service worker is being found and is running.

Screenshot 2020-10-13 152918

@pi0 pi0 closed this as completed in 27e19a0 Oct 13, 2020
@pi0
Copy link
Member

pi0 commented Oct 13, 2020

Hi @shadow81627 this issue is resolved with v3.2.1. We add a query string to start_url to be able detecting standalone ATH starts. Seems latest lighthouse audit needed to explicitly precache exact URL

@RauppRafael
Copy link

Hi @pi0 the commit 27e19a0 seems to be causing issue #375 as it is not adding the revision to the file

@xrei
Copy link

xrei commented Oct 20, 2020

Why do you need to add start_url to precache ? I think its related to bug that i have #384

@dseeker
Copy link

dseeker commented Nov 13, 2020

having the same problem with 3.2.2

@pi0
Copy link
Member

pi0 commented Nov 28, 2020

Hi. This issue should be gone with 3.3.0.

@simonmaass
Copy link

the issue is not gone in 3.3.0!

@pi0
Copy link
Member

pi0 commented Nov 30, 2020

@simonmaass Seems regression was back since adding revision also to start_url as query. Would you please try 3.3.2?

image

@simonmaass
Copy link

@pi0 yeh works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants