Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support paths in localePath() #554

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

sugoidesune
Copy link

@sugoidesune sugoidesune commented Dec 27, 2019

support passing in path as string to localePath()
localePath('/app/profile')

Stackoverflow Conversation

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #554   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         121    121           
  Branches       31     31           
=====================================
  Hits          121    121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6a6f9...dea916e. Read the comment docs.

@rchl
Copy link
Collaborator

rchl commented Jan 10, 2020

Thanks but I would require tests for this too.

@sugoidesune
Copy link
Author

Thanks but I would require tests for this too.

Alright. Found where the tests are. Will try and add a commit soon!

@rchl rchl merged commit 29a282e into nuxt-modules:master Jan 20, 2020
@rchl
Copy link
Collaborator

rchl commented Jan 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants