Skip to content

feat(plugin): support runtimeConfig #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2020
Merged

feat(plugin): support runtimeConfig #387

merged 8 commits into from
Jul 9, 2020
+39 −2

Conversation

SkyaTura
Copy link
Contributor

@SkyaTura SkyaTura commented Jul 7, 2020

This PR adds ctx.$config.axios to the plugin, which solves #386

@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #387 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           32        32           
  Branches        13        13           
=========================================
  Hits            32        32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc50e46...c2bc6d6. Read the comment docs.

pi0
pi0 reviewed Jul 7, 2020
View reviewed changes
pi0
pi0 reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was lazy to finish this feature

@pi0 pi0 changed the title fix(plugin): use runtimeConfig before options feat(plugin): support runtimeConfig Jul 7, 2020
@pi0
Copy link
Member

pi0 commented Jul 7, 2020

@SkyaTura Do you mind also updating the docs?

@SkyaTura
Copy link
Contributor Author

SkyaTura commented Jul 8, 2020

Done @pi0

@SkyaTura SkyaTura requested a review from pi0 July 8, 2020 23:59
pi0
pi0 reviewed Jul 9, 2020
View reviewed changes
pi0
pi0 reviewed Jul 9, 2020
View reviewed changes
pi0
pi0 reviewed Jul 9, 2020
View reviewed changes
pi0
pi0 reviewed Jul 9, 2020
View reviewed changes
pi0
pi0 reviewed Jul 9, 2020
View reviewed changes
docs/options.md Outdated
- `browserBaseURL`

**nuxt.config.js**
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For syntax highlighting, it should be ```js

@pi0 pi0 merged commit 351ea5e into nuxt-community:dev Jul 9, 2020
@pi0
Copy link
Member

pi0 commented Jul 9, 2020

Thanks @SkyaTura ❤️

@SkyaTura SkyaTura mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SkyaTura @pi0