Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function helper setBaseURL #296

Merged
merged 8 commits into from Oct 21, 2019
Merged

feat: add function helper setBaseURL #296

merged 8 commits into from Oct 21, 2019

Conversation

ricardogobbosouza
Copy link
Member

Resolve #155

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #296 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #296   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        28     28           
  Branches     13     13           
===================================
  Hits         28     28
Impacted Files Coverage Δ
lib/module.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb9837...fd62c0c. Read the comment docs.

lib/plugin.js Outdated Show resolved Hide resolved
docs/helpers.md Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 1028bbc into nuxt-community:dev Oct 21, 2019
pi0 pushed a commit that referenced this pull request Oct 23, 2019
@MohitTilwani15
Copy link

Hello @ricardogobbosouza @pi0,

First of all thanks for maintaining this wonderful library. The helper function setBaseUrl is very helpful but I think it is not added in the typings.

@ricardogobbosouza
Copy link
Member Author

ricardogobbosouza commented Jan 29, 2020

Hi @MohitTilwani15 you're right
I created a PR to solve this #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browserBaseURL not change when I change env
3 participants