-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds trait_exists to ensure orchestra/testbench is installed #957
Conversation
I'll wait for #955 |
Thank you @rajyan. This is a very good thought. |
@szepeviktor I added an Exception. |
Please prioritize |
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Thank you! |
resolves #863
Related PRs
I personally think
getcwd()
is not a good solution tofind Laravel Application bootstrap file, but could not find a better solution that solve cases like #856.
so, for cases that Laravel application bootstrap file cannot be loaded by
getcwd().'/bootstrap/app.php'
,I just don't want
and handle bootstrap by my own.
This PR adds
trait_exists
to ensureOrchestra\Testbench\Concerns\CreatesApplication
exists, which is called inApplicationResolver::resolve()
https://github.com/nunomaduro/larastan/blob/master/src/ApplicationResolver.php#L18