fix: add missing relation builder method stubs for custom builder #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
Jul 25, 2021
szepeviktor
changed the title
|
Issues in |
canvural
referenced
this pull request
Jul 26, 2021
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Done. |
|
🛰️ We have successfully deflected the Klingon attack 🍏 |
szepeviktor
approved these changes
Jul 26, 2021
|
Thank you! |
|
Thanks @canvural & @szepeviktor. Great job on this library 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my road to a green screen for larastan, I discovered some missing relation builder methods are missing in the stub. Errors occurs when a custom eloquent builder is used.
Similar to: #896
Changes
Added missing relation methods to stub.