fix: customer eloquent builder return wrong type when whereHas is used
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let us see CI's take on this! |
|
The problem (:x:) comes from here bf1a22f#r53854185 |
|
@canvural Ready to review. Thanks for your help! Edit: Not sure why tests now failing. Locally all have passed. |
szepeviktor
approved these changes
Jul 24, 2021
canvural
changed the title
whereHas is used
|
Thank you! The failing jobs are not related to this. I'll fix them tomorrow. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #897
The return type of the
whereHasmethod (EloquentBuilder stub) was previously wrong, so that when a custom builder is used, thus builder is not correct recognized.