Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add createOneQuietly stub #1462

Merged
merged 4 commits into from Dec 1, 2022
Merged

feat: add createOneQuietly stub #1462

merged 4 commits into from Dec 1, 2022

Conversation

amooij
Copy link
Contributor

@amooij amooij commented Nov 29, 2022 •
edited

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

The factory stub did not have createOneQuietly defined, which prevented PHPStan/Larastan from resolving the type correctly.

Breaking changes

None

@canvural
Copy link
Collaborator

This needs tests added in https://github.com/nunomaduro/larastan/blob/0c9c70ff21e70ac8a90c0b1680cb5a7e5352d0ca/tests/Type/data/model-factories.php

@amooij
Copy link
Contributor Author

amooij commented Nov 29, 2022

This needs tests added in https://github.com/nunomaduro/larastan/blob/0c9c70ff21e70ac8a90c0b1680cb5a7e5352d0ca/tests/Type/data/model-factories.php

Like so?

@canvural canvural changed the title Add createOneQuietly feat: add createOneQuietly stub Dec 1, 2022
@canvural canvural merged commit 00ab8c5 into larastan:master Dec 1, 2022
@canvural
Copy link
Collaborator

canvural commented Dec 1, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canvural canvural canvural requested changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amooij @canvural @szepeviktor