Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS #1450

Merged
merged 4 commits into from Dec 9, 2022
Merged

Fix CS #1450

merged 4 commits into from Dec 9, 2022

Conversation

szepeviktor
Copy link
Collaborator

@szepeviktor szepeviktor commented Nov 20, 2022

We have 100 function foo();
and 27 function bar() {}

What to do now?

@canvural
Copy link
Collaborator

canvural commented Dec 9, 2022

I think every stub should use ;

So can you update this PR to fix everything?

@szepeviktor
Copy link
Collaborator Author

Oh no! Only interfaces may have function foo();

@canvural
Copy link
Collaborator

canvural commented Dec 9, 2022

Not only interfaces but also methods. So only functions should have {}

@szepeviktor
Copy link
Collaborator Author

szepeviktor commented Dec 9, 2022

Not only interfaces but also methods.

I've tried in an overwritten commit above. Everything went berserk ❌

@canvural
Copy link
Collaborator

canvural commented Dec 9, 2022

It was just because of ; at the end of the functions. It didn't complain about methods.

@canvural canvural merged commit d634d4f into master Dec 9, 2022
@canvural canvural deleted the szepeviktor-patch-1 branch December 9, 2022 22:29
@canvural
Copy link
Collaborator

canvural commented Dec 9, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants