feat: support for encrypted and parameterized casts #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdjfisher
changed the title
jdjfisher
commented
Nov 6, 2022
| } | ||
|
|
||
| // Truncate cast parameters | ||
| $type = Str::before($type, ':'); |
There was a problem hiding this comment.
Looking through the framework, it appears to be explicitly looking for decimal:, date:, datetime: etc for the built-in parameterized casts. That said, I think for the interest maintainibility here, we can reasonably assume that everything following the : is parameters and not part of the underlying cast type.
canvural
changed the title
|
Thank you! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for resolving encrypted eloquent cast types.
Added support for resolving underlying eloquent cast types with cast parameters (e.g decimal with precision, datetime with format etc).