feat: conditional return types for Eloquent\Collection::find()
#1419
+38
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally submitted here: laravel/framework#44459
Changes
Thanks to PHPStan's conditional return types, we can now infer what does the
find
method of the Eloquent Collection returns.When the
$key
argument is anarray
or anArrayable
object, it returns a new collection with the found items.In all other cases, it returns a single item, or the
$default
value.