Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1487 #1488

Merged
merged 1 commit into from Dec 23, 2022
Merged

Fix for issue #1487 #1488

merged 1 commit into from Dec 23, 2022

Conversation

rcerljenko
Copy link
Contributor

Fixes #1487

@rcerljenko rcerljenko mentioned this pull request Dec 23, 2022
Closed
@canvural canvural merged commit 2217d07 into larastan:master Dec 23, 2022
@canvural
Copy link
Collaborator

Thank you!

@rcerljenko
Copy link
Contributor Author

rcerljenko commented Dec 23, 2022 •
edited

np.. since we're here could you somehow exclude a folder from that rule? eg: I want to check my views but i dont want to check resources/views/vendor views because mostly i don't use them but they get published with everything else...

@canvural
Copy link
Collaborator

views/vendor should be skipped already. Thanks to this line. Does it not work for you?

@rcerljenko
Copy link
Contributor Author

again... directory separator haha :) i'll provide another PR for that

@rcerljenko
Copy link
Contributor Author

here it is => #1489

@rcerljenko rcerljenko mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with new rule checkUnusedViews on Windows
2 participants
@rcerljenko @canvural