Eagerly detect sortable types for equivalency tests in 3.13.x #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenaw
commented
Nov 27, 2021
| if (TypeHelper.IsTuple(type) || TypeHelper.IsValueTuple(type)) | ||
| { | ||
| foreach (var typeArg in type.GetGenericArguments()) | ||
| if (!typeArg.IsSortable()) |
There was a problem hiding this comment.
Recursively check + confirm that all of a tuple's properties can reasonably be expected to be sortable.
manfred-brands
approved these changes
Nov 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3998
This turned out much simpler than I expected. This PR will eagerly determine if an array can be sorted without issue for equivalency tests. This PR targets 3.13, but I'll cherry-pick the commits to 4.0 once the implementation is finalized.