-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop netcore2.1 as a target #3986
Conversation
c9d7515
to
39b15f2
Compare
The macOS failure on XML files seems unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be convenient to do #3984 at the same time since the overall number of things would remain the same.
In light of @CharliePoole's comments, I drop this. Replaced with #3988 which add .net6. |
Looking at #3988, I think you may have misunderstood me. My point was that I think you need to keep the out of support second-level test assemblies, even though you are dropping 2.1 support from the framework itself. If I'm not mistaken, dropping the actual support is a decision @rprouse has already made. |
The framework itself is targeting The only place I wasn't sure was |
OK, I'd say wait for Rob to to tell you what he wants to do. I thought that he wanted them all gone and I was only arguing for keeping the second-level tests - those that are run by your own tests - in order to be able to prove that a user with a .NET Core 2.1 test can still use NUnit. IMO it's insufficient to just state that analytically. Ya gotta test it! All that said, I'm not a team member and it's just one person's opinion. :-) |
I'd like to drop support for compiling test assemblies to 2.1, so I'd like to see this reopened. |
39b15f2
to
d8c2ccb
Compare
Rebased and also removed installing netcore 2.1 from github actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop netcore2.1 as a target (backport #3986)
Fixes #3980