Add missing [DoesNotReturn] annotations for Assert.Pass, Ignore, and Inconclusive #3958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods always throw an exception. I noticed these were missing when
if (x is null) Assert.Inconclusive(...);
did not cause the compiler to understand thatx
was not null after that line.Looks like I'd already figured this out for
Assume.That
:nunit/src/NUnitFramework/framework/Assume.cs
Lines 134 to 142 in 45cc9cd