Add test verifying equality works for Complex on all platforms #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to merge latest from master to get the build passing. |
stevenaw
force-pushed
the
1809-complex-number-tests
branch
from
56ac4fb
to
e6b50f0
Compare
stevenaw
changed the title
|
Thanks @rprouse |
stevenaw
commented
Dec 29, 2020
| var ExampleTestA = new ExampleTest.ClassA(0); | ||
| var ExampleTestB = new ExampleTest.ClassB(0); | ||
| var exampleTestA = new ExampleTest.ClassA(0); | ||
| var exampleTestB = new ExampleTest.ClassB(0); |
There was a problem hiding this comment.
Fix a few stylecop naming convention warnings while I'm in the file
rprouse
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1809
Draft PR + new test verifying that equality of
Complextypes works on Linux (filed ticket was against .NET Core 1 preview).Complexdoesn't exist on NET35, so test is enclosed in#if !NET35directiveBased on @mikkelbu 's comment in the issue, it's likely this is a runtime bug in
1.0which was fixed in1.1.0and backported to1.0. The original issue: dotnet/runtime#6834