Inconsistency among NUnit2045 "Call independent Assert statements..." vs. NUnit documentation that does not require "independent"

[maettu-this]

Consider this piece of test code where rate = new Rate(interval, window):

Assert.That(rate.Update(10), Is.True);
Assert.That(rate.Value, Is.EqualTo(13));

Assert.That(rate.Update(10), Is.True);
Assert.That(rate.Value, Is.EqualTo(27));

The analyzer (version 3.10 with NUnit 3.14.0) issues "warning NUnit2045: Call independent Assert statements from inside an Assert.Multiple". This statement is not fully correct,...

• ...because calling a method on an object may effect its state, i.e. statements are not "independent".
• ...and NUnit Multiple Asserts does not require "indepentent", whereas the message as well as https://github.com/nunit/nunit.analyzers/blob/master/documentation/NUnit2045.md state so.

Notes:

• The Update() method calculates Value and returns true if Value has changed.
• Rewriting the test using Assert.Multiple() passes:

Assert.Multiple(() =>
{
	Assert.That(rate.Update(10), Is.True);
	Assert.That(rate.Value, Is.EqualTo(13));
});
Assert.Multiple(() =>
{
	Assert.That(rate.Update(10), Is.True);
	Assert.That(rate.Value, Is.EqualTo(27));
});

Potential solutions:

• Remove the "independent" from message and documentation.
• Clarify the intention and constraints of Assert.Multiple() with the NUnit team.