Request: Analyzer to error when non-static OneTimeSetup is used with [FixtureLifeCycle(LifeCycle.InstancePerTestCase)]

[CoenraadS]

As per the NUnit documentation

When using LifeCycle.InstancePerTestCase, the OneTimeSetUp and OneTimeTearDown methods must be static, and each are only called once. This is required so that the setup or teardown methods do not access instance fields or properties that are reset for every test.

I would like to see the analyzer detect the following:

• Error: [FixtureLifeCycleAttribute(LifeCycle.InstancePerTestCase)] & non static [OneTimeSetUp]/[OneTimeTearDown]
  - Error: [FixtureLifeCycleAttribute(LifeCycle.SingleInstance)] & static [OneTimeSetUp]/[OneTimeTearDown]

It would also be great if the analyzer is aware of assembly level attributes, they may not be defined on the class.

[manfred-brands]

Thanks @CoenraadS.

I agree the first part is a good rule to have.
The second though is technically valid, although unnecessary.
I have even seen fixtures were all tests are static. You can even have static fixtures.

[CoenraadS]

Ah interesting. I updated my original issue so only the first one is requested.