Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Explicitly re-export the types in numpy._typing #21243

Merged
merged 1 commit into from Mar 25, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Mar 25, 2022

Partial backport of #21216 (70176f6)


Closes #21214

This PR accomplishes two things:

  • It splits numpy.typing into a public and private sub-package, allowing a greater degree of separation of the public interface from the list of private types and type-aliases. This one in particular has been on my wish list for some time due to the ever growing number of private members.
  • While the public members of the (previously unified) numpy.typing sub-package were already explicitly marked as re-exported, this was not the case for its' private members, resulting in BUG: Usage of implicit reexports breaks using mypy with --no-implicit-reexport #21214. This issues has been rectified in 70176f6, which should be backported to 1.22.4 (I'll create a PR once this one is merged, as I anticipate a merge conflict or two).

@BvB93 BvB93 added this to the 1.22.4 release milestone Mar 25, 2022
@charris charris merged commit 55619bc into numpy:maintenance/1.22.x Mar 25, 2022
@charris
Copy link
Member

charris commented Mar 25, 2022

Thanks Bas. The test failures look unrelated.

@BvB93 BvB93 deleted the re-export branch March 25, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants