REV,BUG: Replace NotImplemented
with typing.Any
#19311
Merged
+24
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial backport of #19176.
Closes #19310.
Replace all
NotImplemented
-based runtime placeholders withtyping.Any
. The problem with the previousapproach is that typing lacks the necessary special-casing for
NotImplemented
, and will thus raise an exceptionwhen used with subscriptable typing constructs (e.g.
Union
).Note that the relevant issue is limited to python 3.7 installations that lack the typing-extensions package.