Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV: revert change to numpyconfig.h for sizeof(type) hardcoding on macOS #22805

Merged
merged 1 commit into from Dec 15, 2022

Conversation

charris
Copy link
Member

@charris charris commented Dec 15, 2022

Backport of #22804.

Reverts gh-22614, and adds more detail about why that code is needed and when it can be removed.

Closes gh-22796

[skip cirrus]
[skip circle]

…macOS

Reverts numpygh-22614, and adds more detail about why that code is needed and
when it can be removed.

Closes numpygh-22796

[skip cirrus]
[skip circle]
@charris charris added 03 - Maintenance 08 - Backport Used to tag backport PRs 34 - Reversion Reversion of previous commit or merge labels Dec 15, 2022
@charris charris added this to the 1.24.0 release milestone Dec 15, 2022
@charris charris removed the 34 - Reversion Reversion of previous commit or merge label Dec 15, 2022
@charris charris merged commit e18104e into numpy:maintenance/1.24.x Dec 15, 2022
@charris charris deleted the backport-22804 branch December 15, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants