Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: Prepare for NumPy 1.21.6 release. #21323

Merged
merged 1 commit into from Apr 11, 2022

Conversation

charris
Copy link
Member

@charris charris commented Apr 11, 2022

  • Create 1.21.6-changelog.rst.
  • Update 1.21.6-notes.rst.
  • Fix circleci doc builds.
  • Change azure-pipelines Mac vmImage to macOS-1015.

@charris charris added this to the 1.21.6 release milestone Apr 11, 2022
@seberg
Copy link
Member

seberg commented Apr 11, 2022

Sorry, I hadn't realize this was coming now. Can you hold off until tomorrow?

@charris
Copy link
Member Author

charris commented Apr 11, 2022

Can you hold off until tomorrow?

Sure. This came up at the end of scipy/oldest-supported-numpy#45. Do you intend to add something?

@seberg
Copy link
Member

seberg commented Apr 11, 2022

Yeah, there is one small fix I have been meaning to do for a while and it should be quick.

@seberg
Copy link
Member

seberg commented Apr 11, 2022

Oh, just realized that this is 1.21.x not 1.22.x. Still happy to backport, though, but maybe not as pressing. (and there is a tiny chance of backcompat issues, so only if a 1.21.7 wouldn't be too much hassle.)

@charris
Copy link
Member Author

charris commented Apr 11, 2022

I'd rather avoid any potential problems. I wouldn't do this at all if the oldest-supported-numpy problem hadn't come up.

@charris
Copy link
Member Author

charris commented Apr 11, 2022

A 1.22 fix would be welcome, though. Things there have quieted a lot since 1.22.3, so probably only one more release.

- Create 1.21.6-changelog.rst.
- Update 1.21.6-notes.rst.
- Fix circleci doc builds.
- Change azure-pipelines Mac vmImage to macOS-1015.
- Use Python 3.8 for typing tests on Mac.
@Czaki
Copy link
Contributor

Czaki commented Apr 11, 2022

if this release will be able to build from source on Windows? CCompiler_spawn() got an unexpected keyword argument 'env' observed when building numpy==1.21.5 from source using latest setuptools:

          File "C:\Users\RUNNER~1\AppData\Local\Temp\pip-build-env-v9k16mu4\overlay\site-packages\setuptools\_distutils\_msvccompiler.py", line 505, in spawn
                  return super().spawn(cmd, env=env)
          File "C:\Users\RUNNER~1\AppData\Local\Temp\pip-install-u4z7ehkd\numpy_abda04e05c5e4cc9b598abfa5c2eb061\numpy\distutils\ccompiler.py", line 90, in <lambda>
                  m = lambda self, *args, **kw: func(self, *args, **kw)
        TypeError: CCompiler_spawn() got an unexpected keyword argument 'env'

https://github.com/4DNucleome/PartSegCore-compiled-backend/runs/5972857498?check_suite_focus=true#step:4:708

As I read test-related scripts the test process uses the system python which does not use latest setuptools.

@charris
Copy link
Member Author

charris commented Apr 11, 2022

@Czaki NumPy often does not build with latest setuptools, which are changing regularly these days. We are pinned to older versions and will change the build to use meson at some point on account of the instability. Windows builds are difficult in any case and are best avoided when possible.

@charris
Copy link
Member Author

charris commented Apr 11, 2022

@BvB93 I'm trying to do a 1.21.6 release, but am now getting typing errors for no reason I can see. Could you take a look at the error messages and see if there is anything that can be easily fixed? Something has changed.

EDIT: The tests run without problems on my machine, the errors seem to be Mac specific, and possibly due to the azure-pipeline environment.

@Czaki
Copy link
Contributor

Czaki commented Apr 11, 2022

@charris Thanks for your response. Now I check and setuptools is pinned in pyproject.toml. So I do not understand why it fails.

I would love to avoid numpy builds but I also would love to deliver pypy wheels.

@mattip
Copy link
Member

mattip commented Apr 11, 2022

@Czaki you can get PyPy wheels for windows from the weekly builds

pypy -m pip install -i https://pypi.anaconda.org/scipy-wheels-nightly/simple numpy==1.23.0.dev0

If this doesn't work or is not what you want, please open a separate issue.

@BvB93
Copy link
Member

BvB93 commented Apr 11, 2022

EDIT: The tests run without problems on my machine, the errors seem to be Mac specific, and possibly due to the azure-pipeline environment.

Same here on my Mac; locally the tests pass without issue. It's not clear to me what could be causing the issue here, though based on the reproducibility issue presumably something related to azure?

@charris
Copy link
Member Author

charris commented Apr 11, 2022

presumably something related to azure?

Sounds like it, they have broken things before, it is really annoying. Guess I'll put this in and see if the wheel builds pass. If not, is there an easy way to disable the tests?

@charris charris merged commit ef0ec78 into numpy:maintenance/1.21.x Apr 11, 2022
@charris charris deleted the prepare-1.21.6-release branch April 11, 2022 23:43
@BvB93
Copy link
Member

BvB93 commented Apr 12, 2022

Sounds like it, they have broken things before, it is really annoying. Guess I'll put this in and see if the wheel builds pass. If not, is there an easy way to disable the tests?

We could always add an xfail for Mac with these specific tests.

@charris
Copy link
Member Author

charris commented Apr 12, 2022

We could always add an xfail for Mac with these specific tests.

The wheel builds passed. Not sure what the differences are, need to take a look at that someday.

@BvB93
Copy link
Member

BvB93 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants