BUG: Fix setstate logic for empty arrays #20681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up the clearing of the mem_handler slightly. Lets try to make sure it is always NULL when OWNDATA is not set (and an error is given), just so there can't be any accidental double-frees. Obviously, this function has more problems then the ones fixed here... This introduces the NBYTES_ALLOCATED helper basically just for these two places to fix the UHOH prints also...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20954.
Also cleans up the clearing of the mem_handler slightly. Lets try
to make sure it is always NULL when OWNDATA is not set (and an error
is given), just so there can't be any accidental double-frees.
Obviously, this function has more problems then the ones fixed here...
This introduces the NBYTES_ALLOCATED helper basically just for these
two places to fix the UHOH prints also...