Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Verify the ability to compile C++ sources before initiating the build #20464

Merged
merged 2 commits into from Nov 26, 2021
Merged

BLD: Verify the ability to compile C++ sources before initiating the build #20464

merged 2 commits into from Nov 26, 2021

Conversation

charris
Copy link
Member

@charris charris commented Nov 25, 2021

Backport of #20354.

related to #20335

@charris charris added 08 - Backport Used to tag backport PRs 36 - Build Build related PR labels Nov 25, 2021
@charris charris added this to the 1.21.5 release milestone Nov 25, 2021
@charris charris merged commit 1d1f044 into numpy:maintenance/1.21.x Nov 26, 2021
@charris charris deleted the backport-20354 branch November 26, 2021 01:44
charris added a commit to charris/numpy that referenced this pull request Dec 19, 2021
@charris
REV: Revert pull request numpy#20464 from charris/backport-20354
45d9b13 
This reverts commit 1d1f044, reversing changes made to 157ee4f.

The backport was in error, as there is no C++ in NumPy 1.21.x. The
change caused problems with the manylinux1 compiler, which is not
C++11 compatible.
@takluyver takluyver mentioned this pull request Jan 7, 2022
Open
charris added a commit to charris/numpy that referenced this pull request Apr 10, 2022
@charris
REV: Revert pull request numpy#20464 from charris/backport-20354
30ba38c 
This reverts commit 1d1f044, reversing changes made to 157ee4f.

The backport was in error, as there is no C++ in NumPy 1.21.x. The
change caused problems with the manylinux1 compiler, which is not
C++11 compatible.
charris added a commit that referenced this pull request Apr 11, 2022
@charris
Merge pull request #21318 from charris/revert-20354
68ff2d3 
REV: Revert pull request #20464 from charris/backport-20354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
08 - Backport Used to tag backport PRs 36 - Build Build related PR
Projects
None yet
Milestone
1.21.5 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charris @seiko2plus