Typing test error in maintenance/1.21.x

[charris]

@BvB93 I'm seeing the following test failure after this:

_____________________________________________________ test_reveal[arrayterator.py] _____________________________________________________

path = '/home/charris/Workspace/numpy.git/build/testenv/lib64/python3.9/site-packages/numpy/typing/tests/data/reveal/arrayterator.py'
reveal = "'typing.Generator[numpy.signedinteger[numpy.typing._64Bit], None, None]"
expected_reveal = '13: note: Revealed type is "typing.Generator[numpy.signedinteger[numpy.typing._64Bit], None, None]"', lineno = 13

    def _test_reveal(path: str, reveal: str, expected_reveal: str, lineno: int) -> None:
        if reveal not in expected_reveal:
>           raise AssertionError(_REVEAL_MSG.format(lineno, expected_reveal, reveal))
E           AssertionError: Reveal mismatch at line 13
E           
E           Expected reveal: '13: note: Revealed type is "typing.Generator[numpy.signedinteger[numpy.typing._64Bit], None, None]"'
E           Observed reveal: "'typing.Generator[numpy.signedinteger[numpy.typing._64Bit], None, None]"

expected_reveal = '13: note: Revealed type is "typing.Generator[numpy.signedinteger[numpy.typing._64Bit], None, None]"'
lineno     = 13
path       = '/home/charris/Workspace/numpy.git/build/testenv/lib64/python3.9/site-packages/numpy/typing/tests/data/reveal/arrayterator.py'
reveal     = "'typing.Generator[numpy.signedinteger[numpy.typing._64Bit], None, None]"

This is with python 3.9.7. This also shows up in 1.21.3 (previous release) and seems new, probably something in my environment has changed.

[charris]

Note that the main branch is OK.

[BvB93]

I wonder why this was never caught before? A different mypy version perhaps?
In any case, #20302 will get rid of the offending stray quotation mark.

[BvB93]

Closed by #20302.

[BvB93]

@charris I was wondering, since the numpy.typing test suite is rather tightly linked to specific mypy versions,
would it be worthwhile to backport mypy test_requirements.txt updates in the future?

[charris]

@BvB93 Sounds like a good idea.