Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Deprecate error clearing in array-protocol attribute fetching #18199

Closed
seberg opened this issue Jan 21, 2021 · 0 comments · Fixed by #19001
Closed

DEP: Deprecate error clearing in array-protocol attribute fetching #18199

seberg opened this issue Jan 21, 2021 · 0 comments · Fixed by #19001

Comments

@seberg
Copy link
Member

seberg commented Jan 21, 2021

See gh-18197, we currently clear almost all errors that occur when fetching obj.__array_interface__ or just obj.__array__. There is little use for this, since by definition AttributeError can be raised if an object actually wants the error to be ignored. Shapely dependend on this (raising a NotImplementedError).

We should deprecate ignoring these errors entirely. There are more similar cases, although this issue is about the interface/array path.

(Will assign myself, but if anyone wants to look at it, feel free)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant