Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update 1.17.x with 1.18.0-dev pocketfft.py. #14436

Merged
merged 1 commit into from Sep 6, 2019

Conversation

charris
Copy link
Member

@charris charris commented Sep 6, 2019

Backport of #14279,

BUG: fix issue #14176

This replaces the fct variable in pocketfft.py by its inverse, inv_fct. The actual factor is only built immediately before executing the FFT. This defers potential divide-by-zero exceptions until after the check for zero-length transforms.

The easiest way to backport #14279 was to copy pocketfft.py from master.
That also brings some improved documentation and other fixes with it, which
cannot hurt.

Easiest way to backport numpy#14279 is to copy the affected file. That also
brings some improved documentation and other fixes with it, which cannot
hurt.
@charris charris added this to the 1.17.2 release milestone Sep 6, 2019
@charris charris added the 08 - Backport Used to tag backport PRs label Sep 6, 2019
@rgommers
Copy link
Member

rgommers commented Sep 6, 2019

Noticing this only now and not specific to this PR but: yet again missing underscores in a filename. dir(np.fft) shows pocketfft and pocketfft_internal, that should be fixed up and preferably also backported to 1.17.x

@charris charris merged commit e1febea into numpy:maintenance/1.17.x Sep 6, 2019
@charris charris deleted the backport-14279 branch September 6, 2019 01:36
@charris
Copy link
Member Author

charris commented Sep 6, 2019

@rgommers Is it your suggestion that pocketfft_internal should be renamed _pocketfft?

@rgommers
Copy link
Member

rgommers commented Sep 6, 2019

No, pocketfft.py should be renamed _pocketfft.py, and pocketfft_internal should be _pocketfft_internal. The rule is simple: those things are private, so must start with an underscore.

@charris
Copy link
Member Author

charris commented Sep 6, 2019

To be consistent, then we should probably rename pocketfft.c to pocketfft_internal.c

@grlee77
Copy link
Contributor

grlee77 commented Sep 6, 2019

Thanks for backporting this @charris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants