Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate/discuss setuptools build and runtime dependency versions. #8617

Closed
stuartarchibald opened this issue Nov 23, 2022 · 3 comments
Closed
Labels
discussion An issue requiring discussion

Comments

@stuartarchibald
Copy link
Contributor

xref: #8475 (comment), with thanks to @mbargull for raising this.

Seems like setuptools=65.6.0 has broken numpy.distutils (same way as last time #8355), the NumPy tracking issue is here numpy/numpy#22623.

NumPy folks have pinned to setuptools=59.2 numpy/numpy#22623 (comment) and are not supporting 60+ numpy/numpy#22623 (comment).

I think that #8544 removes all most all of Numba's reliance on numpy.distutils which is the part that keeps on being broken. Only the to-be-deprecated-in-0.57 pycc module has reference to numpy.distutils still.

Further xref: #8476 which needs work but makes setuptools optional at runtime.

@stuartarchibald stuartarchibald added the discussion An issue requiring discussion label Nov 23, 2022
@mbargull
Copy link
Contributor

Ah, I didn't realize gh-8544 replaced numpy.distutils.misc_util.get_info('npymath') with numpy.get_include() (plus the accompanying changes). Yes, that'd probably take care of the build-time dependencies, thanks!

@stuartarchibald
Copy link
Contributor Author

Ah, I didn't realize gh-8544 replaced numpy.distutils.misc_util.get_info('npymath') with numpy.get_include() (plus the accompanying changes). Yes, that'd probably take care of the build-time dependencies, thanks!

@mbargull No worries, raising this is really helpful, esp. the part about NumPy's policy, thanks again for that! The original intention of #8544 was to remove use of npymath.a and to fix up some ufunc loops, but having done this I realised the side effect was being able to largely drop use of numpy.distutils etc. As noted, hopefully this will prevent related future build-time issues!

@stuartarchibald
Copy link
Contributor Author

#8544 drops numpy.distutils as noted previously, then #8476 and #8842 make setuptools optional at runtime. Closing as fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion An issue requiring discussion
Projects
None yet
Development

No branches or pull requests

2 participants