Release 0.56 branch: Fix overloads with target="generic" for CUDA
#8570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As identified in numba#8271, the CUDA target needs to be set as the target at the bottom of the call stack, otherwise overloads for the generic target cannot be resolved. This is required so that the fix applied in numba#8562 (using the generic target for `ol_compatible_view` from numba#8537) actually works.
stuartarchibald
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks for the patch, I've tested this locally and it fixes the noted issue. I think it also makes sense that this would be needed as the path that's failing is quite likely unaware of what the current target is as it has CUDA lowering calling typing and lowering on a 'generic' target.
stuartarchibald
added
the
4 - Waiting on CI
|
|
These were all green. |
esc
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #8271, the CUDA target needs to be set as the target at the bottom of the call stack, otherwise overloads for the generic target cannot be resolved. This is required so that the fix applied in #8562 (using the generic target for
ol_compatible_viewfrom #8537) actually works.