Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry picks 0.56.4 #8562

Merged
merged 3 commits into from Nov 2, 2022
Merged

Cherry picks 0.56.4 #8562

merged 3 commits into from Nov 2, 2022

Conversation

esc
Copy link
Member

@esc esc commented Nov 1, 2022 •
edited

As Title

@sklam @esc
Merge pull request numba#8537 from gmarkall/issue-8529
ff10487 
Make ol_compatible_view accessible on all targets
@sklam @esc
Merge pull request numba#8552 from stuartarchibald/doc/0564_version_s…
e79251c 
…upport_update

Update version support table for 0.56.4.
@sklam @esc
Merge pull request numba#8553 from stuartarchibald/wip/change_log_056_4
059b8ca 
Update CHANGE_LOG for 0.56.4
@esc esc mentioned this pull request Nov 1, 2022
Closed
35 tasks
@esc esc added this to the Numba 0.56.4 milestone Nov 1, 2022
stuartarchibald
stuartarchibald approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I replayed the merges from #8537, #8552 and #8553 manually onto a local copy of the release0.56 branch and the git diff against this PR is empty, which suggests it is correct. Manually inspecting the changes, they look as expected. The RTD build looks ok on manual inspection too.

@stuartarchibald
Copy link
Contributor

NOTE: The build failure on the Linux py39_np120_doc build is due to #8548 which is fixed on branch main by #8549 but not on target branch for this PR (branch release0.56). The issue is rstcheck related which only occurs on Azure CI, hence RTD and the buildfarm should be ok.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed and removed 3 - Ready for Review labels Nov 1, 2022
@esc esc added 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Nov 2, 2022
@esc
Copy link
Member Author

esc commented Nov 2, 2022

@stuartarchibald thank you for the review!

@esc esc merged commit 2c108f9 into numba:release0.56 Nov 2, 2022
@gmarkall
Copy link
Member

gmarkall commented Nov 2, 2022

gpuci run tests

gmarkall added a commit to gmarkall/numba that referenced this pull request Nov 2, 2022
@gmarkall
Fix overloads with target="generic" for CUDA
4c4e319 
As identified in numba#8271, the CUDA target needs to be set as the target at
the bottom of the call stack, otherwise overloads for the generic target
cannot be resolved. This is required so that the fix applied in numba#8562
(using the generic target for `ol_compatible_view` from numba#8537) actually
works.
@gmarkall gmarkall mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@sklam sklam Awaiting requested review from sklam sklam is a code owner

Assignees

@stuartarchibald stuartarchibald

Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.56.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@esc @stuartarchibald @gmarkall @sklam