Make ol_compatible_view accessible on all targets #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix Issue numba#8529, where test_reinterpret_array_type fails on CUDA with NumPy 1.23 because this overload is needed. Making it accessible to the CUDA target should resolve the issue.
|
gpuci run tests |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stuartarchibald
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Thanks for the patch. This has been manually tested locally as part of debugging: #8529 (comment). I think it also makes sense as the most minimally invasive method to resolve the problem, i.e. the CUDA target using some lowering from the CPU target that calls out to an @overload... that @overload needs to be for the generic target else the CUDA target cannot "see" it.
Further, as gpuci is now passing (it wasn't in #8532, or by induction the merge to main in 9d034e9) this also suggests the fix is working.
stuartarchibald
added
Pending BuildFarm
sklam
added
5 - Ready to merge
esc
pushed a commit
to esc/numba
that referenced
this pull request
Nov 1, 2022
Make ol_compatible_view accessible on all targets
|
Buildfarm ID: Passed. |
gmarkall
added a commit
to gmarkall/numba
that referenced
this pull request
Nov 2, 2022
As identified in numba#8271, the CUDA target needs to be set as the target at the bottom of the call stack, otherwise overloads for the generic target cannot be resolved. This is required so that the fix applied in numba#8562 (using the generic target for `ol_compatible_view` from numba#8537) actually works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix Issue #8529, where test_reinterpret_array_type fails on CUDA with NumPy 1.23 because this overload is needed. Making it accessible to the CUDA target should resolve the issue.
Fixes #8529.