Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for 0.56.2 #8414

Merged
merged 6 commits into from Sep 2, 2022
Merged

Hotfix for 0.56.2 #8414

merged 6 commits into from Sep 2, 2022

Conversation

sklam
Copy link
Member

@sklam sklam commented Sep 1, 2022

as titled

@sklam
Copy link
Member Author

sklam commented Sep 1, 2022

numba_smoketest_cpu_yaml_126

@esc esc changed the title Bump NumPy pinning in meta.yaml hotfix for 0.56.2 Sep 1, 2022
@esc esc changed the title hotfix for 0.56.2 Hotfix for 0.56.2 Sep 1, 2022
@sklam sklam marked this pull request as ready for review September 2, 2022 00:43
sklam
sklam commented Sep 2, 2022
View reviewed changes
CHANGE_LOG Outdated Show resolved Hide resolved
sklam
sklam commented Sep 2, 2022
View reviewed changes
CHANGE_LOG Outdated Show resolved Hide resolved
esc
esc requested changes Sep 2, 2022
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL appears to have been shortened.

CHANGE_LOG Outdated Show resolved Hide resolved
@sklam @esc
Fix accidentally shortened url
b80e438 
Co-authored-by: esc <esc@users.noreply.github.com>
@sklam sklam requested a review from esc September 2, 2022 01:00
esc
esc approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when public CI passes.

@esc esc added the 4 - Waiting on CI Review etc done, waiting for CI to finish label Sep 2, 2022
@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish labels Sep 2, 2022
@sklam sklam added this to the Numba 0.56.1 milestone Sep 2, 2022
@sklam sklam merged commit d6731f6 into numba:release0.56 Sep 2, 2022
@sklam sklam deleted the misc/update_meta_yaml branch September 2, 2022 02:30
esc added a commit to esc/numba that referenced this pull request Sep 7, 2022
@esc
Merge pull request numba#8414 from sklam/misc/update_meta_yaml
394defb 
Hotfix for 0.56.2
@esc esc mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esc esc esc approved these changes

@stuartarchibald stuartarchibald Awaiting requested review from stuartarchibald stuartarchibald is a code owner

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.56.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sklam @esc