Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick for 0.56 release #8279

Merged
merged 3 commits into from Jul 25, 2022
Merged

Cherry pick for 0.56 release #8279

merged 3 commits into from Jul 25, 2022

Conversation

sklam
Copy link
Member

@sklam sklam commented Jul 25, 2022

as titled.

@sklam
Merge pull request numba#8274 from stuartarchibald/doc/056_version_su…
d617754 
…pport_update

Update version support table doc for 0.56.
@sklam
Merge pull request numba#8275 from stuartarchibald/wip/change_log_056…
2717e7a 
…_final

Update CHANGE_LOG for 0.56.0 final
@sklam sklam added this to the Numba 0.56.0 milestone Jul 25, 2022
@sklam sklam mentioned this pull request Jul 25, 2022
Closed
25 tasks
stuartarchibald
stuartarchibald reviewed Jul 25, 2022
View reviewed changes
CHANGE_LOG Outdated
@@ -265,12 +265,16 @@ Pull-Requests:
* PR `#8187 <https://github.com/numba/numba/pull/8187>`_: Update CHANGE_LOG for 0.55.2 (`stuartarchibald <https://github.com/stuartarchibald>`_ `esc <https://github.com/esc>`_)
* PR `#8189 <https://github.com/numba/numba/pull/8189>`_: updated version support information for 0.55.2/0.57 (`esc <https://github.com/esc>`_)
* PR `#8191 <https://github.com/numba/numba/pull/8191>`_: CUDA: Update deprecation notes for 0.56. (`Graham Markall <https://github.com/gmarkall>`_)
* PR `#8192 <https://github.com/numba/numba/pull/8192>`_: Update CHANGE_LOG for 0.56.0 (`stuartarchibald <https://github.com/stuartarchibald>`_ `esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)
* PR `#8195 <https://github.com/numba/numba/pull/8195>`_: Make the workqueue threading backend once again fork safe. (`stuartarchibald <https://github.com/stuartarchibald>`_)
* PR `#8196 <https://github.com/numba/numba/pull/8196>`_: Fix numerical tolerance in parfors caching test. (`stuartarchibald <https://github.com/stuartarchibald>`_)
* PR `#8197 <https://github.com/numba/numba/pull/8197>`_: Fix `isinstance` warning check test. (`stuartarchibald <https://github.com/stuartarchibald>`_)
* PR `#8203 <https://github.com/numba/numba/pull/8203>`_: pin llvmlite 0.39 for public CI builds (`esc <https://github.com/esc>`_)
* PR `#8192 <https://github.com/numba/numba/pull/8192>`_: Update CHANGE_LOG for 0.56.0 (`stuartarchibald <https://github.com/stuartarchibald>`_ `esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should be removed, as it is out of order, incorrectly indented, and covered above by a new correct entry in the right place.

stuartarchibald
stuartarchibald reviewed Jul 25, 2022
View reviewed changes
CHANGE_LOG Outdated
@@ -265,12 +265,16 @@ Pull-Requests:
* PR `#8187 <https://github.com/numba/numba/pull/8187>`_: Update CHANGE_LOG for 0.55.2 (`stuartarchibald <https://github.com/stuartarchibald>`_ `esc <https://github.com/esc>`_)
* PR `#8189 <https://github.com/numba/numba/pull/8189>`_: updated version support information for 0.55.2/0.57 (`esc <https://github.com/esc>`_)
* PR `#8191 <https://github.com/numba/numba/pull/8191>`_: CUDA: Update deprecation notes for 0.56. (`Graham Markall <https://github.com/gmarkall>`_)
* PR `#8192 <https://github.com/numba/numba/pull/8192>`_: Update CHANGE_LOG for 0.56.0 (`stuartarchibald <https://github.com/stuartarchibald>`_ `esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)
* PR `#8195 <https://github.com/numba/numba/pull/8195>`_: Make the workqueue threading backend once again fork safe. (`stuartarchibald <https://github.com/stuartarchibald>`_)
* PR `#8196 <https://github.com/numba/numba/pull/8196>`_: Fix numerical tolerance in parfors caching test. (`stuartarchibald <https://github.com/stuartarchibald>`_)
* PR `#8197 <https://github.com/numba/numba/pull/8197>`_: Fix `isinstance` warning check test. (`stuartarchibald <https://github.com/stuartarchibald>`_)
* PR `#8203 <https://github.com/numba/numba/pull/8203>`_: pin llvmlite 0.39 for public CI builds (`esc <https://github.com/esc>`_)
* PR `#8192 <https://github.com/numba/numba/pull/8192>`_: Update CHANGE_LOG for 0.56.0 (`stuartarchibald <https://github.com/stuartarchibald>`_ `esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)
* PR `#8205 <https://github.com/numba/numba/pull/8205>`_: Pin llvmlite and NumPy on release branch.(`esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* PR `#8205 <https://github.com/numba/numba/pull/8205>`_: Pin llvmlite and NumPy on release branch.(`esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)
* PR `#8205 <https://github.com/numba/numba/pull/8205>`_: Pin llvmlite and NumPy on release branch.(`esc <https://github.com/esc>`_ `Siu Kwan Lam <https://github.com/sklam>`_)

@sklam sklam marked this pull request as ready for review July 25, 2022 16:44
@sklam sklam requested a review from esc as a code owner July 25, 2022 16:44
stuartarchibald
stuartarchibald approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I've checked this manually by replaying the cherry-picks of the merges and resolving conflicts similarly and it seems to match up!

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish Effort - short Short size effort needed and removed 3 - Ready for Review labels Jul 25, 2022
@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish labels Jul 25, 2022
@sklam
Copy link
Member Author

sklam commented Jul 25, 2022

enough CI has passed for doc changes. going to merge

@sklam sklam merged commit f75c45a into numba:release0.56 Jul 25, 2022
@sklam sklam deleted the misc/rel0.56cherry branch July 25, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@esc esc Awaiting requested review from esc esc is a code owner

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.56.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sklam @stuartarchibald