Fix dynamic calculation #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 96.05% 96.23% +0.18%
==========================================
Files 17 17
Lines 1547 1621 +74
==========================================
+ Hits 1486 1560 +74
Misses 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Nukesor
force-pushed
the
fix-dynamic-calculation
branch
2 times, most recently
from
0d12c56
to
df46087
Compare
Nukesor
force-pushed
the
fix-dynamic-calculation
branch
from
df46087
to
ae051f9
Compare
This bug has been introduced in commit bee764d, when doing the refactoring on how column content widths were calculated. The old logic worked with the full width including paddings, the new logic however only worked with the content width. Due to this, columns were sometimes pinned to a width that was too small for their actual content.
The proptest suite now contains extensive tests that ensure constraints will be respected.
Nukesor
force-pushed
the
fix-dynamic-calculation
branch
from
0306748
to
286ff73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90