Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'Self' to refer to own type #63

Merged
merged 1 commit into from Jan 30, 2022

Conversation

danieleades
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #63 (4222f44) into main (0358051) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   97.37%   97.12%   -0.25%     
==========================================
  Files          14       14              
  Lines         800      800              
==========================================
- Hits          779      777       -2     
- Misses         21       23       +2     
Impacted Files Coverage Δ
src/column.rs 100.00% <ø> (ø)
src/table.rs 85.81% <ø> (ø)
src/utils/mod.rs 100.00% <ø> (ø)
src/cell.rs 100.00% <100.00%> (ø)
src/row.rs 100.00% <100.00%> (ø)
src/utils/arrangement/dynamic.rs 98.51% <0.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0358051...4222f44. Read the comment docs.

@Nukesor
Copy link
Owner

Nukesor commented Jan 30, 2022

There's a conflict with your other MR, but otherwise this looks good to me :)

@Nukesor Nukesor merged commit 12eadbe into Nukesor:main Jan 30, 2022
@danieleades danieleades deleted the refactor/use-self branch January 30, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants